Fix header only api singletons (#1520) #1604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix is for gcc and clang only.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1604 +/- ##
==========================================
+ Coverage 85.22% 85.30% +0.09%
==========================================
Files 156 156
Lines 4978 4978
==========================================
+ Hits 4242 4246 +4
+ Misses 736 732 -4
|
3 tasks
owent
reviewed
Sep 9, 2022
Member
owent
left a comment
owent
left a comment
There was a problem hiding this comment.
Should we disable component_c .. component_f and keep component_a and component_b on Windows?
3 tasks
Do not build unit test code in windows.
lalitb
reviewed
Sep 13, 2022
lalitb
approved these changes
Sep 13, 2022
owent
approved these changes
Sep 13, 2022
Member
Author
Thanks. |
yxue
pushed a commit
to yxue/opentelemetry-cpp
that referenced
this pull request
Dec 5, 2022
yxue
pushed a commit
to yxue/opentelemetry-cpp
that referenced
this pull request
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is for gcc and clang only.
Fixes #1520
Changes
Add compiler annotations to make singleton methods visible.
This is needed by the linker to ensure uniqueness of singletons.
CHANGELOG.mdupdated for non-trivial changes