MetricStorage dtors #1270
Merged
MetricStorage dtors #1270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1270 +/- ##
==========================================
+ Coverage 92.37% 92.37% +0.01%
==========================================
Files 202 203 +1
Lines 7336 7338 +2
==========================================
+ Hits 6776 6778 +2
Misses 560 560
|
DebajitDas
pushed a commit
to DebajitDas/opentelemetry-cpp
that referenced
this pull request
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing MetricStorage virtual dtors
Please provide a brief description of the changes here.
Also adds clangd cache to gitignore.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes