Skip to content

[Metric SDK] Synchronous Instruments - Aggregation Storage(s) creation for configured views #1219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lalitb merged 18 commits into from
Feb 24, 2022
Merged

[Metric SDK] Synchronous Instruments - Aggregation Storage(s) creation for configured views #1219

lalitb merged 18 commits into from
Feb 24, 2022

Conversation

@lalitb
Copy link
Member

@lalitb lalitb commented Feb 18, 2022 •
edited
Loading

Fixes #1217

Changes

Create and store Aggregation Storage(s) as per the logic described in #1217

Refer to the flow in architecture ( https://docs.google.com/document/d/17PiDI91MQy07kkiSJ7lvlnogvMD3FV85g__WEackj1M ) which shows Aggregation Storage as SyncMetricStorage and AsyncMetricStorage, and the same name is used in the code.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@lalitb lalitb requested a review from a team February 18, 2022 00:41
@codecov
Copy link

codecov bot commented Feb 18, 2022 •
edited
Loading

Codecov Report

Merging #1219 (7947f1e) into main (9157fd4) will decrease coverage by 0.66%.
The diff coverage is 61.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1219      +/-   ##
==========================================
- Coverage   92.96%   92.31%   -0.65%     
==========================================
  Files         196      198       +2     
  Lines        7040     7118      +78     
==========================================
+ Hits         6544     6570      +26     
- Misses        496      548      +52
Impacted Files Coverage Δ
...ntelemetry/sdk/metrics/view/attributes_processor.h 100.00% <ø> (ø)
sdk/include/opentelemetry/sdk/metrics/view/view.h 66.67% <0.00%> (+3.04%) ⬆️
sdk/src/metrics/meter_context.cc 36.37% <0.00%> (-1.73%) ⬇️
sdk/test/metrics/sync_metric_storage_test.cc 100.00% <ø> (ø)
sdk/src/metrics/meter.cc 8.83% <4.55%> (-9.35%) ⬇️
sdk/test/metrics/multi_metric_storage_test.cc 68.43% <68.43%> (ø)
...telemetry/sdk/metrics/state/multi_metric_storage.h 84.62% <84.62%> (ø)
...ntelemetry/sdk/metrics/state/sync_metric_storage.h 52.95% <100.00%> (ø)
...clude/opentelemetry/sdk/metrics/sync_instruments.h 100.00% <100.00%> (ø)
sdk/src/metrics/sync_instruments.cc 100.00% <100.00%> (ø)
... and 2 more

esigo
esigo reviewed Feb 19, 2022
View reviewed changes
esigo
esigo reviewed Feb 19, 2022
View reviewed changes
esigo
esigo reviewed Feb 19, 2022
View reviewed changes
esigo
esigo reviewed Feb 19, 2022
View reviewed changes
esigo
esigo approved these changes Feb 20, 2022
View reviewed changes
Copy link
Member

@esigo esigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for the PR.

@lalitb lalitb merged commit c10bc36 into open-telemetry:main Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@esigo esigo esigo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Metric SDK] - Sync Instruments - Aggregation Storage(s) creation for configured views.

2 participants

@lalitb @esigo