Use custom abseil with bazel #1172
Conversation
Signed-off-by: owentou <[email protected]>
Signed-off-by: owentou <[email protected]>
Signed-off-by: owentou <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1172 +/- ##
=======================================
Coverage 93.29% 93.29%
=======================================
Files 174 174
Lines 6402 6402
=======================================
Hits 5972 5972
Misses 430 430
|
bazel/repository.bzl
Outdated
| http_archive, | ||
| name = "com_google_absl", | ||
| sha256 = "59b862f50e710277f8ede96f083a5bb8d7c9595376146838b9580be90374ee1f", | ||
| strip_prefix = "abseil-cpp-20210324.2", |
There was a problem hiding this comment.
abseil version doesn't match with what we use in CI: 20210324.0
There was a problem hiding this comment.
Fixed. The version of internal abseil in api/include/opentelemetry/nostd/absl is v2020-03-03#8 ,should it be upgraded?
There was a problem hiding this comment.
The version of internal abseil in api/include/opentelemetry/nostd/absl is v2020-03-03#8, should it be upgraded?
One of the concerns I see with the periodic upgrade of the internal nostd::variant snapshot would be the ABI incompatibility issue if the instrumented library and application are built using different otel-cpp releases (having different nostd::variant snapshots).
Signed-off-by: owentou <[email protected]>
lalitb
left a comment
lalitb
left a comment
There was a problem hiding this comment.
LGTM. Thanks for fixing this issue.
api/BUILD
Outdated
| "@com_google_absl//absl/base", | ||
| "@com_google_absl//absl/types:any", | ||
| "@com_google_absl//absl/types:variant", | ||
| "@com_google_absl//absl/types:span", |
There was a problem hiding this comment.
nit - do we need to add a dependency for absl::span?
There was a problem hiding this comment.
@com_google_absl//absl/types:any and @com_google_absl//absl/types:span are removed. The failed jobs seem not be the problem of this PR.
Signed-off-by: owentou <[email protected]>
4 participants
Fixes #1065
Changes
api/include/opentelemetry/nostd/absltoapi/include/opentelemetry/nostd/internal/absl--//api:with_abseil=trueto use external abseil when use bazel to build.bazel_with_abseilinto.github/workflows/ci.ymlto test building with external abseil.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes