-
Notifications
You must be signed in to change notification settings - Fork 512
Closed
Labels
StalebugSomething isn't workingSomething isn't workinghelp wantedGood for taking. Extra help will be provided by maintainersGood for taking. Extra help will be provided by maintainerstriage/acceptedIndicates an issue or PR is ready to be actively worked on.Indicates an issue or PR is ready to be actively worked on.
Description
As documented in Specs - https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/protocol/exporter.md#opentelemetry-protocol-exporter
Compression: Compression key for supported compression types. Supported compression: gzip.
Default: No value [2]
Env vars: OTEL_EXPORTER_OTLP_COMPRESSION OTEL_EXPORTER_OTLP_TRACES_COMPRESSION OTEL_EXPORTER_OTLP_METRICS_COMPRESSION OTEL_EXPORTER_OTLP_LOGS_COMPRESSION
High level changes for OTLP HTTP Exporter:
- Add compression option (gzip/none) in OtlpHttpExporterOptions, OtlpHttpLogRecordExporterOptions, OtlpHttpMetricExporterOptions. Default is
none. - Modify ext::http::client::curl to
- If compression option is enabled,
- Make a HEAD request to server to validate if
gzipencoding is accepted. ( ? )
- If accepted, compress the data usingzlib, and setContent-Encoding: gzipheader.
- If not accepted, send uncompressed data and log a warning
- Make a HEAD request to server to validate if
- If compression option is not enabled,
- send uncompressed data to server as done now.
- If compression option is enabled,
High level changes for OTLP gRPC Exporter:
- Add compression option (gzip/none) in OtlpGrpcExporterOptions. Default is
none. - Modify OtlpGrpcClient::MakeChannel to set the compression algorithm for the channel if enabled. Refer gRPC compression example here - https://github.com/grpc/grpc/blob/master/examples/cpp/compression/README.md#writing-a-client-and-a-server.
kkuehl, owent and marcalff
Metadata
Metadata
Assignees
Labels
StalebugSomething isn't workingSomething isn't workinghelp wantedGood for taking. Extra help will be provided by maintainersGood for taking. Extra help will be provided by maintainerstriage/acceptedIndicates an issue or PR is ready to be actively worked on.Indicates an issue or PR is ready to be actively worked on.