Skip to content

[CMake Build] Install necessary header files only? #1980

@ThomsonTan

Description

@ThomsonTan

Follow up for #1932 (comment)

we install all headers when we run cmake --install now.In my understanding, is it better to select a subset of headers to install(all exported classes and their dependencies). Maybe we can also improve it in another PR.

For cmake, we install header files as below, @owent, do you think we should list the files to install explicitly instead of relying on pattern with wildcard?

install(
DIRECTORY include/opentelemetry
DESTINATION include
FILES_MATCHING
PATTERN "*.h"
PATTERN "metrics" EXCLUDE)

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingdo-not-stalegood first issueGood for newcomershelp wantedGood for taking. Extra help will be provided by maintainers

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions