-
Notifications
You must be signed in to change notification settings - Fork 513
Open
Labels
bugSomething isn't workingSomething isn't workingdo-not-stalegood first issueGood for newcomersGood for newcomershelp wantedGood for taking. Extra help will be provided by maintainersGood for taking. Extra help will be provided by maintainers
Description
Follow up for #1932 (comment)
we install all headers when we run cmake --install now.In my understanding, is it better to select a subset of headers to install(all exported classes and their dependencies). Maybe we can also improve it in another PR.
For cmake, we install header files as below, @owent, do you think we should list the files to install explicitly instead of relying on pattern with wildcard?
opentelemetry-cpp/api/CMakeLists.txt
Lines 24 to 29 in 6f0a30e
| install( | |
| DIRECTORY include/opentelemetry | |
| DESTINATION include | |
| FILES_MATCHING | |
| PATTERN "*.h" | |
| PATTERN "metrics" EXCLUDE) |
lalitb
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingdo-not-stalegood first issueGood for newcomersGood for newcomershelp wantedGood for taking. Extra help will be provided by maintainersGood for taking. Extra help will be provided by maintainers