- To avoid conflict with the new LogRecord class, rename existing sdk::logs::LogRecord class to some better name (say sdk::logs::LogRecordData).
- Add setter for observed_timestamp in sdk:logs::Reordable and sdk::logs::LogRecordData.
- Similar to Span's Recordable, add a getter method for LogRecordData in Recordable class. This can be eventually implemented by all it's derived implementation (not in scope for now).
/**
* Get the LogRecordData object for this Recordable.
*
* @return LogRecordData*
*/
virtual explicit operator LogRecordData *() const { return nullptr; }
This would let us avoid having ReadWriteLogRecord class. This method can be potentially used inside LogRecordProcessor to filter the logs based on it's contents (not in scope for now).
This would let us avoid having
ReadWriteLogRecordclass. This method can be potentially used insideLogRecordProcessorto filter the logs based on it's contents (not in scope for now).