Remove .instrumentation/development.general.peer.service_mapping#526
Merged
codeboten merged 2 commits intoopen-telemetry:mainfrom Feb 6, 2026
Merged
Remove .instrumentation/development.general.peer.service_mapping#526codeboten merged 2 commits intoopen-telemetry:mainfrom
.instrumentation/development.general.peer.service_mapping#526codeboten merged 2 commits intoopen-telemetry:mainfrom
Conversation
Member
|
I defer to semantic conventions folks for whether we should drop or adapt this. Could drop it and open an issue to solicit whether any users want this feature. We took a similar approach with zipkin span exporter, jaeger propagator, and ot trace propagator. All these concepts were deprecated at the spec level, and rather than going stable with deprecated types, we deleted them and are willing to bring them back as deprecated if upon user request. |
Member
Author
|
There's nothing in semantic conventions about peer service mapping. |
Member
|
Then I hallucinated this property (or more likely added through the lens of java agent config) and we can delete. |
jack-berg
approved these changes
Feb 6, 2026
codeboten
approved these changes
Feb 6, 2026
This was referenced Feb 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #520
peer.servicehas been renamed toservice.peer.name, andservice.peer.namespacehas been introduced.We could adapt the name (see #520), but I think Java is the only language that has implemented this mapping concept, and it's not super convenient since it's all manual work for users. After semconv discussions, it seems like
service.peer.namewill typically be added in an ingestion pipeline where it can be automatically populated from a span tree based on the known remoteservice.name, e.g. in some kind of a span-to-metrics pipeline.So I think my recommendation would be to drop it from the configuration model, at least until there's greater demand. But also don't mind if you prefer #520.