Skip to content

Conversation

@jack-berg
Copy link
Member

Did a thorough pass on the java implementation and updated current implementation status.

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the best way to review this? Should someone in the Java implementation review the status?

Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a configuration SIG member I can say the syntax looks good. I'd like to have another Java SIG member give this a review for content before merging.

@jack-berg
Copy link
Member Author

Will reach out to the java SIG. TBH, its a tough ask because a thorough review requires the reviewer to go through the implementation with a fine tooth comb like I needed to do to open this PR. I favor rubber stamps for this type of thing, and followup fixes if / when discovered.

@jack-berg jack-berg merged commit d5fff6f into open-telemetry:main Nov 4, 2025
12 checks passed
@jack-berg
Copy link
Member Author

Ah good catch @zeitlinger! I think I made an error merging conflicts from #362 since I called out support for specific properties while indicating that ConsoleMetricExporter itself was unsupported. Fixed in #380.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants