-
Notifications
You must be signed in to change notification settings - Fork 33
Update java implementation status #364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update java implementation status #364
Conversation
codeboten
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the best way to review this? Should someone in the Java implementation review the status?
MrAlias
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a configuration SIG member I can say the syntax looks good. I'd like to have another Java SIG member give this a review for content before merging.
|
Will reach out to the java SIG. TBH, its a tough ask because a thorough review requires the reviewer to go through the implementation with a fine tooth comb like I needed to do to open this PR. I favor rubber stamps for this type of thing, and followup fixes if / when discovered. |
|
@jack-berg reviewing even though merged: |
|
Ah good catch @zeitlinger! I think I made an error merging conflicts from #362 since I called out support for specific properties while indicating that ConsoleMetricExporter itself was unsupported. Fixed in #380. |
Did a thorough pass on the java implementation and updated current implementation status.