[receiver/prometheus] Use appenderv2#45597
Closed
ArthurSens wants to merge 8 commits intoopen-telemetry:mainfrom
Closed
[receiver/prometheus] Use appenderv2#45597ArthurSens wants to merge 8 commits intoopen-telemetry:mainfrom
ArthurSens wants to merge 8 commits intoopen-telemetry:mainfrom
Conversation
Signed-off-by: Arthur Silva Sens <[email protected]>
Signed-off-by: Arthur Silva Sens <[email protected]>
Signed-off-by: Arthur Silva Sens <[email protected]>
Signed-off-by: Arthur Silva Sens <[email protected]>
Signed-off-by: Arthur Silva Sens <[email protected]>
Signed-off-by: Arthur Silva Sens <[email protected]>
Signed-off-by: Arthur Silva Sens <[email protected]>
bwplotka
reviewed
Jan 23, 2026
| if err != nil { | ||
| return err | ||
| } | ||
| scrapeManager, err = scrape.NewManager(opts, logger, nil, nil, storeV2, r.registerer) |
Contributor
There was a problem hiding this comment.
FYI: For this to work functionally the same you need to change your initial scrape opts a bit:
- Important:
opts.AppendMetadata = truebecause with V2 you obtain meta from Append, not from context/metadata store hack we did for collector. - PassMetadataInContext = false to save some CPU/allocs and stop using this hack, so we can remove it eventually.
22 tasks
Signed-off-by: Arthur Silva Sens <[email protected]>
Contributor
|
From the WG today: We love the idea of simplifying all of this, and the prototype is super-helpful. I wonder if it is possible when we do the migration in small pieces. Is it possible to implement the new appender interface using the old functions, and then refactor in small steps? |
Contributor
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Contributor
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a heavily WIP PR, the goal is mostly to provide feedback to prometheus/prometheus#17872