Skip to content

Make service discoveries removable through Go build tags#45148

Merged
atoulme merged 3 commits intoopen-telemetry:mainfrom
ArthurSens:removable-sds
Jan 21, 2026
Merged

Make service discoveries removable through Go build tags#45148
atoulme merged 3 commits intoopen-telemetry:mainfrom
ArthurSens:removable-sds

Conversation

@ArthurSens
Copy link
Copy Markdown
Member

@ArthurSens ArthurSens commented Dec 24, 2025 •
edited
Loading

Description

This PR is built on top of prometheus/prometheus#17736. There are a lot of go mod changes, and that also inherits fixes to interface changes that were made since Prometheus 3.8

The only change that is really about making SDs removable is this change in imports in factory.go:

-	_ "github.com/prometheus/prometheus/discovery/install" // init() of this package registers service discovery impl.
+	_ "github.com/prometheus/prometheus/plugins" // init() of this package registers service discovery impl.

Link to tracking issue

Fixes #44406

Testing

Used two builder configs and measured the binary size difference:

Without build tags(120MB):

dist:
  module: github.com/open-telemetry/otelcontribcol
  name: otelcontribcol
  version: 0.143.0
  output_path: ./cmd/otelcontribcol/sd-test/full

receivers:
  - gomod: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/prometheusreceiver v0.143.0
    path: ./receiver/prometheusreceiver

exporters:
  - gomod: go.opentelemetry.io/collector/exporter/debugexporter v0.143.0

With build tags(63MG):

dist:
  module: github.com/open-telemetry/otelcontribcol
  name: otelcontribcol
  version: 0.143.0
  output_path: ./cmd/otelcontribcol/sd-test/no-sd
  build_tags: "remove_all_sd"

receivers:
  - gomod: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/prometheusreceiver v0.143.0
    path: ./receiver/prometheusreceiver

exporters:
  - gomod: go.opentelemetry.io/collector/exporter/debugexporter v0.143.0

@ArthurSens
Copy link
Copy Markdown
Member Author

ArthurSens commented Dec 24, 2025

I'm opening this PR just to show how it works, but discussions should be done upstream at prometheus/prometheus :)

@atoulme atoulme marked this pull request as draft January 2, 2026 07:28
@atoulme
Copy link
Copy Markdown
Contributor

atoulme commented Jan 2, 2026

Moving to draft since this is not to be merged.

@ArthurSens ArthurSens mentioned this pull request Jan 8, 2026
Closed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 17, 2026

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jan 17, 2026
@ArthurSens ArthurSens marked this pull request as ready for review January 19, 2026 12:53
@ArthurSens
Copy link
Copy Markdown
Member Author

ArthurSens commented Jan 19, 2026 •
edited
Loading

PR finally ready for review @dashpole :)

I've also updated the PR description to mention how to test these changes

@ArthurSens
Make service discoveries removable through Go Build tags
2501954 
Signed-off-by: Arthur Silva Sens <[email protected]>
@ArthurSens
Add changelog entry
8b0d786 
Signed-off-by: Arthur Silva Sens <[email protected]>
@ArthurSens
Fix changelog entry
c40d814 
Signed-off-by: Arthur Silva Sens <[email protected]>
@github-actions github-actions bot removed the Stale label Jan 20, 2026
atoulme
atoulme approved these changes Jan 21, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atoulme atoulme merged commit 6f1d79c into open-telemetry:main Jan 21, 2026
191 checks passed
@ArthurSens ArthurSens deleted the removable-sds branch January 21, 2026 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atoulme atoulme atoulme approved these changes

@dashpole dashpole dashpole approved these changes

@fatsheep9146 fatsheep9146 Awaiting requested review from fatsheep9146

@mx-psi mx-psi Awaiting requested review from mx-psi

@songy23 songy23 Awaiting requested review from songy23

@braydonk braydonk Awaiting requested review from braydonk

@jsuereth jsuereth Awaiting requested review from jsuereth

@aabmass aabmass Awaiting requested review from aabmass

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@ankitpatel96 ankitpatel96 Awaiting requested review from ankitpatel96

@chrroberts-pure chrroberts-pure Awaiting requested review from chrroberts-pure

@dgoscn dgoscn Awaiting requested review from dgoscn

@dineshg13 dineshg13 Awaiting requested review from dineshg13

@gouthamve gouthamve Awaiting requested review from gouthamve

@IbraheemA IbraheemA Awaiting requested review from IbraheemA

@jade-guiton-dd jade-guiton-dd Awaiting requested review from jade-guiton-dd

@krajorama krajorama Awaiting requested review from krajorama

@liustanley liustanley Awaiting requested review from liustanley

@mackjmr mackjmr Awaiting requested review from mackjmr

@mar4uk mar4uk Awaiting requested review from mar4uk

@perebaj perebaj Awaiting requested review from perebaj

@psx95 psx95 Awaiting requested review from psx95

@rapphil rapphil Awaiting requested review from rapphil

@ridwanmsharif ridwanmsharif Awaiting requested review from ridwanmsharif

@ywwg ywwg Awaiting requested review from ywwg

Assignees

@TylerHelmuth TylerHelmuth

@MovieStoreGuy MovieStoreGuy

Labels

exporter/googlemanagedprometheus Google Managed Prometheus exporter exporter/prometheus exporter/prometheusremotewrite internal/datadog/e2e pkg/translator/loki pkg/translator/prometheusremotewrite receiver/loki receiver/prometheus Prometheus receiver receiver/prometheusremotewrite receiver/purefa receiver/purefb receiver/simpleprometheus testbed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[prometheusreceiver] Consider separating prom service discovery from the receiver module

5 participants

@ArthurSens @atoulme @dashpole @TylerHelmuth @MovieStoreGuy