[exporter/awsxrayexporter] Merge in latest semconv for awsxrayexporter.#36894
Merged
Conversation
srprash
approved these changes
Dec 20, 2024
andrzej-stencel
approved these changes
Dec 24, 2024
AkhigbeEromo
pushed a commit
to sematext/opentelemetry-collector-contrib
that referenced
this pull request
Jan 13, 2025
…r. (open-telemetry#36894) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description The PR merge in latest semconv pkg and update existing semantic conventions utilization. And further update `awsxrayexporter` to be able to handle following both new versions of http span attributes: `http.response.status_code` migrated from [http.status_code](https://opentelemetry.io/docs/specs/semconv/attributes-registry/http/#http-status-code) `url.query` migrated from [http.target](https://opentelemetry.io/docs/specs/semconv/attributes-registry/http/#http-target). Otel Java SDK has renamed `telemetry.auto.version` to `telemetry.distro.version` ([Upstream PR](open-telemetry/opentelemetry-java-instrumentation#9065)), update `awsxrayexporter` to be able to detect both attributes. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue N/A <!--Describe what testing was performed and which tests were added.--> #### Testing Unit test passed <!--Describe the documentation added.--> #### Documentation N/A
zeck-ops
pushed a commit
to zeck-ops/opentelemetry-collector-contrib
that referenced
this pull request
Apr 23, 2025
…r. (open-telemetry#36894) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description The PR merge in latest semconv pkg and update existing semantic conventions utilization. And further update `awsxrayexporter` to be able to handle following both new versions of http span attributes: `http.response.status_code` migrated from [http.status_code](https://opentelemetry.io/docs/specs/semconv/attributes-registry/http/#http-status-code) `url.query` migrated from [http.target](https://opentelemetry.io/docs/specs/semconv/attributes-registry/http/#http-target). Otel Java SDK has renamed `telemetry.auto.version` to `telemetry.distro.version` ([Upstream PR](open-telemetry/opentelemetry-java-instrumentation#9065)), update `awsxrayexporter` to be able to detect both attributes. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue N/A <!--Describe what testing was performed and which tests were added.--> #### Testing Unit test passed <!--Describe the documentation added.--> #### Documentation N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The PR merge in latest semconv pkg and update existing semantic conventions utilization. And further update
awsxrayexporterto be able to handle following both new versions of httpspan attributes:
http.response.status_codemigrated from http.status_codeurl.querymigrated from http.target.Otel Java SDK has renamed
telemetry.auto.versiontotelemetry.distro.version(Upstream PR), updateawsxrayexporterto be able to detect both attributes.Link to tracking issue
N/A
Testing
Unit test passed
Documentation
N/A