[pdata/pprofile] fix wrong error sentinel in SetString#15511
Merged
Conversation
SetString returned errTooManyMappingTableEntries when the StringTable reached capacity, a copy-paste error from a sibling function. This caused callers checking for a full StringTable via errors.Is to not match the returned error. Fix this by returning errTooManyStringTableEntries instead. Signed-off-by: Florian Lehner <[email protected]>
Signed-off-by: Florian Lehner <[email protected]>
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #15511 +/- ##
=======================================
Coverage 91.08% 91.08%
=======================================
Files 726 726
Lines 47937 47937
=======================================
Hits 43664 43664
Misses 2978 2978
Partials 1295 1295 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mx-psi
approved these changes
Jun 29, 2026
Merged
via the queue into
open-telemetry:main
with commit Jun 29, 2026
45a36a4
68 of 69 checks passed
lazureykis
added a commit
to lazureykis/opentelemetry-collector
that referenced
this pull request
Jul 6, 2026
- FromAttributeIndices now returns (pcommon.Map, error) after open-telemetry#15517; update the assertSampleDictAttr test helper to check the error. - setString now returns errTooManyStringTableEntries, matching the sentinel fix in open-telemetry#15511; drop the stale "preserve parity" workaround. Assisted-by: Claude Opus 4.8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SetString returned errTooManyMappingTableEntries when the StringTable reached capacity, a copy-paste error from a sibling function. This caused callers checking for a full StringTable via errors.Is to not match the returned error.
Fix this by returning errTooManyStringTableEntries instead.
Link to tracking issue
Fixes #
Testing
Documentation
Authorship