[cmd/schemagen] Fix mode detection and add manual override for schemagen package targeting#15453
Merged
Merged
Conversation
…gen package targeting
1 task
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15453 +/- ##
=======================================
Coverage 90.79% 90.79%
=======================================
Files 719 719
Lines 47168 47187 +19
=======================================
+ Hits 42825 42844 +19
Misses 3085 3085
Partials 1258 1258 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
iblancasa
approved these changes
Jun 16, 2026
dmitryax
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change fixes mode detection for
-pby resolving the target package's on-disk source directory via a lightweightpackages.Loadcall before reading itsmetadata.yaml. This works for any package reachable from the local module graph, including cross-repo dependencies present in the module cache. When the package is not in the local module graph, detection falls back to the existing default; a new-m component|packageflag is provided as a manual override for that case.Testing
Changes covered with unit tests.
Documentation
Updated
README.md.Authorship