[cmd/mdatagen] Fix: correct acronym handling in FormatIdentifier#15438
Merged
Conversation
Add issue tracking for the identifier formatting fix.
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (75.00%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #15438 +/- ##
=======================================
Coverage 91.34% 91.34%
=======================================
Files 709 709
Lines 46237 46237
=======================================
Hits 42236 42236
Misses 2788 2788
Partials 1213 1213 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dmitryax
approved these changes
Jun 12, 2026
Co-authored-by: Dmitry Anoshin <[email protected]>
Merged
via the queue into
open-telemetry:main
with commit Jun 12, 2026
bdcc84c
65 of 68 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix
FormatIdentifierso that a property/attribute/metric name that is exactly a known acronym generates the correct all-caps Go identifier (e.g.id->ID,url->URL,http->HTTP).Note: any component whose metadata defines a metric, attribute, or event name that is exactly a standalone acronym (e.g.
cpu,id,url) will have its generated exported Go identifier renamed on next regeneration — this is a source-breaking change for code that references such a generated constant directly.Testing
Updated corresponding unit tests.
Authorship