Skip to content

[cmd/mdatagen] remove stale files#15423

Merged
codeboten merged 7 commits into
open-telemetry:mainfrom
codeboten:codeboten/update-mdatagen-genrules
Jun 16, 2026
Merged

[cmd/mdatagen] remove stale files#15423
codeboten merged 7 commits into
open-telemetry:mainfrom
codeboten:codeboten/update-mdatagen-genrules

Conversation

@codeboten

@codeboten codeboten commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

A bug in mdatagen was causing generated files to be left behind when the last feature gate in a metadata.yaml file was removed.

@codeboten
[cmd/mdatagen] remove stale files
d0dc777 
A bug in mdatagen was causing generated files to be left behind when the last feature gate in a metadata.yaml file was removed.

Signed-off-by: Alex Boten <[email protected]>
@codeboten
codeboten requested review from a team and dmitryax as code owners June 9, 2026 17:05
codeboten
codeboten commented Jun 9, 2026
View reviewed changes
Comment thread .chloggen/codeboten_fix-mdatagen-bug.yaml Outdated
@codeboten
codeboten enabled auto-merge June 9, 2026 17:08
@codspeed-hq

codspeed-hq Bot commented Jun 9, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

✅ 5 untouched benchmarks
⏩ 2 skipped benchmarks1

Comparing codeboten:codeboten/update-mdatagen-genrules (c44bd79) with main (d04d642)

Open in CodSpeed

Footnotes

  1. 2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@codecov

codecov Bot commented Jun 9, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.78%. Comparing base (d04d642) to head (c44bd79).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
cmd/mdatagen/internal/command.go 60.00% 2 Missing and 2 partials ⚠️

❌ Your patch check has failed because the patch coverage (60.00%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #15423      +/-   ##
==========================================
- Coverage   90.79%   90.78%   -0.01%     
==========================================
  Files         719      719              
  Lines       47168    47178      +10     
==========================================
+ Hits        42825    42831       +6     
- Misses       3085     3087       +2     
- Partials     1258     1260       +2

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions Bot added the release:risky-change This change may affect the release label Jun 9, 2026
evan-bradley
evan-bradley approved these changes Jun 16, 2026
View reviewed changes

@evan-bradley evan-bradley left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

Comment thread Makefile.Common
@codeboten
codeboten added this pull request to the merge queue Jun 16, 2026
Merged via the queue into open-telemetry:main with commit 5a9e607 Jun 16, 2026
67 of 68 checks passed
@codeboten
codeboten deleted the codeboten/update-mdatagen-genrules branch June 16, 2026 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evan-bradley evan-bradley evan-bradley approved these changes
@dmitryax dmitryax Awaiting requested review from dmitryax dmitryax is a code owner

Assignees

No one assigned

Labels

cmd/mdatagen release:risky-change This change may affect the release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@codeboten @evan-bradley