Skip to content

[pkg/service] remove stable gate telemetry.UseLocalHostAsDefaultMetricsAddress#15419

Merged
codeboten merged 2 commits into
open-telemetry:mainfrom
codeboten:codeboten/rm-UseLocalHostAsDefaultMetricsAddress
Jun 9, 2026
Merged

[pkg/service] remove stable gate telemetry.UseLocalHostAsDefaultMetricsAddress#15419
codeboten merged 2 commits into
open-telemetry:mainfrom
codeboten:codeboten/rm-UseLocalHostAsDefaultMetricsAddress

Conversation

@codeboten

@codeboten codeboten commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@codeboten
codeboten requested a review from a team as a code owner June 9, 2026 14:33
@codeboten
codeboten requested a review from songy23 June 9, 2026 14:33
codeboten
codeboten commented Jun 9, 2026
View reviewed changes
Comment thread .chloggen/codeboten_rm-UseLocalHostAsDefaultMetricsAddress.yaml Outdated
@codspeed-hq

codspeed-hq Bot commented Jun 9, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 27.05%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
✅ 6 untouched benchmarks

Performance Changes

Benchmark BASE HEAD Efficiency
⚡ BenchmarkGRPCLogsSequential 5.5 ms 4.3 ms +27.05%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.

Comparing codeboten:codeboten/rm-UseLocalHostAsDefaultMetricsAddress (4693b25) with main (c400a79)

Open in CodSpeed

@codeboten
codeboten enabled auto-merge June 9, 2026 14:44
@codecov

codecov Bot commented Jun 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.27%. Comparing base (ac10805) to head (4693b25).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #15419      +/-   ##
==========================================
- Coverage   91.27%   91.27%   -0.01%     
==========================================
  Files         709      709              
  Lines       46224    46224              
==========================================
- Hits        42192    42189       -3     
- Misses       2817     2819       +2     
- Partials     1215     1216       +1

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codeboten
codeboten added this pull request to the merge queue Jun 9, 2026
Merged via the queue into open-telemetry:main with commit 3298566 Jun 9, 2026
69 checks passed
@codeboten
codeboten deleted the codeboten/rm-UseLocalHostAsDefaultMetricsAddress branch June 9, 2026 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@songy23 songy23 songy23 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@codeboten @songy23