[exporter/exporterhelper] mark exporter.PersistRequestContext as stable#15330
Conversation
This feature gate has been in beta for 15 versions, it's time to stabilize it. Signed-off-by: Alex Boten <[email protected]>
Signed-off-by: Alex Boten <[email protected]>
Merging this PR will improve performance by 27.66%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ⚡ | BenchmarkTraceSizeSpanCount |
60 ns | 47 ns | +27.66% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing codeboten:codeboten/stabilize-exporter.PersistRequestContext (c7dc4d9) with main (58cb3e5)
Footnotes
-
76 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15330 +/- ##
==========================================
+ Coverage 91.23% 91.24% +0.01%
==========================================
Files 706 706
Lines 46165 46165
==========================================
+ Hits 42118 42124 +6
+ Misses 2836 2832 -4
+ Partials 1211 1209 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Follow up to open-telemetry#15330 --------- Signed-off-by: Alex Boten <[email protected]>
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [go.opentelemetry.io/collector/component](https://github.com/open-telemetry/opentelemetry-collector) | `v1.58.0` → `v1.59.0` |  |  | | [go.opentelemetry.io/collector/component/componenttest](https://github.com/open-telemetry/opentelemetry-collector) | `v0.152.0` → `v0.153.0` |  |  | | [go.opentelemetry.io/collector/confmap](https://github.com/open-telemetry/opentelemetry-collector) | `v1.58.0` → `v1.59.0` |  |  | | [go.opentelemetry.io/collector/consumer](https://github.com/open-telemetry/opentelemetry-collector) | `v1.58.0` → `v1.59.0` |  |  | | [go.opentelemetry.io/collector/consumer/consumertest](https://github.com/open-telemetry/opentelemetry-collector) | `v0.152.0` → `v0.153.0` |  |  | | [go.opentelemetry.io/collector/pdata](https://github.com/open-telemetry/opentelemetry-collector) | `v1.58.0` → `v1.59.0` |  |  | | [go.opentelemetry.io/collector/processor](https://github.com/open-telemetry/opentelemetry-collector) | `v1.58.0` → `v1.59.0` |  |  | | [go.opentelemetry.io/collector/processor/processortest](https://github.com/open-telemetry/opentelemetry-collector) | `v0.152.0` → `v0.153.0` |  |  | --- ### Release Notes <details> <summary>open-telemetry/opentelemetry-collector (go.opentelemetry.io/collector/component)</summary> ### [`v1.59.0`](https://github.com/open-telemetry/opentelemetry-collector/blob/HEAD/CHANGELOG.md#v1590v01530) ##### 🛑 Breaking changes 🛑 - `pkg/configoptional`: Stabilize feature gate configoptional.AddEnabledField ([#​15333](open-telemetry/opentelemetry-collector#15333)) - `pkg/confmap`: Stabilize confmap.newExpandedValueSanitizer feature gate ([#​15339](open-telemetry/opentelemetry-collector#15339)) - `pkg/exporterhelper`: mark exporter.PersistRequestContext as stable ([#​15330](open-telemetry/opentelemetry-collector#15330)) - `pkg/otelcol`: Stabilize otelcol.printInitialConfig gate ([#​15340](open-telemetry/opentelemetry-collector#15340)) - `pkg/pdata`: Remove pdata.useCustomProtoEncoding feature gate ([#​15332](open-telemetry/opentelemetry-collector#15332)) - `pkg/service`: Stabilize telemetry.UseLocalHostAsDefaultMetricsAddress gate ([#​15342](open-telemetry/opentelemetry-collector#15342)) - `pkg/xpdata`: Stabilize pdata.enableRefCounting feature gate ([#​15331](open-telemetry/opentelemetry-collector#15331)) ##### 🧰 Bug fixes 🧰 - `pkg/config/configgrpc`: Fix memory corruption and fatal error in Snappy ([#​15237](open-telemetry/opentelemetry-collector#15237), [#​15320](open-telemetry/opentelemetry-collector#15320)) <!-- previous-version --> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My41LjQiLCJ1cGRhdGVkSW5WZXIiOiI0My41LjQiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbXX0=--> Reviewed-on: https://gitea.t000-n.de/t.behrendt/tracebasedlogsampler/pulls/73 Reviewed-by: t.behrendt <[email protected]> Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>
This feature gate has been in beta for 15 versions, it's time to stabilize it.