feat(mdatagen): enforce feature name naming and reference links#15310
Merged
codeboten merged 5 commits intoMay 20, 2026
Conversation
TylerHelmuth
commented
May 15, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15310 +/- ##
=======================================
Coverage 91.23% 91.24%
=======================================
Files 706 706
Lines 46165 46171 +6
=======================================
+ Hits 42118 42127 +9
+ Misses 2836 2834 -2
+ Partials 1211 1210 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
As expected some existing feature gates now fail. We'd need to deal with those before merging. |
dmitryax
approved these changes
May 16, 2026
mx-psi
reviewed
May 18, 2026
mx-psi
left a comment
Member
There was a problem hiding this comment.
This looks good, but I think we should have some sort of allowlist feature/escape hatch for now so we don't have to rename existing feature gates
Member
Author
|
Added a new |
codeboten
approved these changes
May 20, 2026
codeboten
enabled auto-merge
May 20, 2026 22:27
Merged
via the queue into
open-telemetry:main
with commit May 20, 2026
46aa7c5
54 of 55 checks passed
jkoronaAtCisco
pushed a commit
to jkoronaAtCisco/opentelemetry-collector
that referenced
this pull request
May 21, 2026
…#15341) #### Description At the moment `go get go.opentelemetry.io/collector/cmd/mdatagen@main` result in an unbuildable `mdatagen`. This happens because mdatagen's go.mod on main references `go.opentelemetry.io/collector/internal/schemagen v0.152.1`. `mdatagen` was [updated](https://github.com/open-telemetry/opentelemetry-collector/pull/15304/changes#diff-42498599bf5b805dde7cc8403116834d346c7cbb62150935aeda205a61886661R60) to depend on a new field from `internal/schemagen` (`InternalOnly`) on main and this new field is not in `go.opentelemetry.io/collector/internal/schemagen v0.152.1`. When building externally (without the replace statements) the dependency is resolved to `v0.152.1` and the compile fails because `v0.152.1` does not have the new field. My fix is to bump `mdatagen`'s dependency to a psuedo version of the tip of main. All of this will get cleaned up with the `v0.153.0` release, but I'd like to do this now so I can bump Contrib's core deps to the tip of main so I can handle the breaking change from open-telemetry#15310 before the release. #### Testing I ran a quick test locally using this commit's psuedo version and confirmed I was able to install mdatagen now
TylerHelmuth
added a commit
to TylerHelmuth/opentelemetry-collector-contrib
that referenced
this pull request
May 21, 2026
open-telemetry/opentelemetry-collector#15310 added two enforcements to mdatagen: feature-gate IDs must be prefixed with `<class>.<type>.` and reference URLs must point at GitHub issues. Many existing gates predate these rules. Set `skip_strict_validation: true` on each grandfathered gate so `make generate` succeeds. New gates should leave the field unset. Signed-off-by: Tyler Helmuth <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds to enforcements to mdatagen's feature gate feature.
<kind>.>id>, such asprocessor.transform.Issue
Testing
updated tests