Skip to content

Enable mdatagen reaggregation by default#15305

Merged
codeboten merged 2 commits into
open-telemetry:mainfrom
dmitryax:mdatagen-reaggregation-default
May 22, 2026
Merged

Enable mdatagen reaggregation by default#15305
codeboten merged 2 commits into
open-telemetry:mainfrom
dmitryax:mdatagen-reaggregation-default

Conversation

@dmitryax

@dmitryax dmitryax commented May 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

All the components upstream got the reaggregation feature enabled open-telemetry/opentelemetry-collector-contrib#45396. reaggregation_enabled option can be set to true by default now.

@codspeed-hq

codspeed-hq Bot commented May 14, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 34.81%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 3 improved benchmarks
✅ 4 untouched benchmarks
⏩ 76 skipped benchmarks1

Performance Changes

Benchmark BASE HEAD Efficiency
⚡ BenchmarkBatchMetricProcessor2k 163.1 ms 125.5 ms +30.01%
⚡ BenchmarkHTTPProtoLogsSequential 4.9 ms 3.6 ms +35.77%
⚡ BenchmarkGRPCLogsSequential 6.1 ms 4.4 ms +38.8%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.

Comparing dmitryax:mdatagen-reaggregation-default (da33ff9) with main (27d23c6)

Open in CodSpeed

Footnotes

  1. 76 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@codecov

codecov Bot commented May 14, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.27%. Comparing base (27d23c6) to head (da33ff9).
⚠️ Report is 27 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #15305      +/-   ##
==========================================
+ Coverage   91.25%   91.27%   +0.02%     
==========================================
  Files         705      705              
  Lines       46084    46087       +3     
==========================================
+ Hits        42056    42068      +12     
+ Misses       2822     2808      -14     
- Partials     1206     1211       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dmitryax
dmitryax marked this pull request as ready for review May 14, 2026 23:28
@dmitryax
dmitryax requested a review from a team as a code owner May 14, 2026 23:28
@dmitryax
dmitryax requested a review from TylerHelmuth May 14, 2026 23:28
codeboten
codeboten approved these changes May 22, 2026
View reviewed changes

@codeboten codeboten left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@codeboten
codeboten added this pull request to the merge queue May 22, 2026
Merged via the queue into open-telemetry:main with commit 3073e35 May 22, 2026
89 of 91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codeboten codeboten codeboten approved these changes
@TylerHelmuth TylerHelmuth Awaiting requested review from TylerHelmuth TylerHelmuth is a code owner automatically assigned from open-telemetry/collector-approvers

Assignees

No one assigned

Labels

cmd/mdatagen

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dmitryax @codeboten