Skip to content

[confmap] Stabilize confmap validation facilities#15142

Merged
mx-psi merged 6 commits into
open-telemetry:mainfrom
evan-bradley:stabilize-validator
May 8, 2026
Merged

[confmap] Stabilize confmap validation facilities#15142
mx-psi merged 6 commits into
open-telemetry:mainfrom
evan-bradley:stabilize-validator

Conversation

@evan-bradley

@evan-bradley evan-bradley commented Apr 17, 2026

Copy link
Copy Markdown
Member

Description

The xconfmap.Validator interface has existed in some form for a very long time now and is ready to be stabilized. Similarly, the xconfmap.Validate method has existed in it's current state for over a year and doesn't have any open issues I'm aware of. It should also be ready for stabilization.

Many modules depend on xconfmap merely for the validation facilities (as can be seen by the go.mod diffs), so this will allow them to depend on only stable modules.

@codecov

codecov Bot commented Apr 17, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.32143% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.23%. Comparing base (56e1235) to head (056e1cb).

Files with missing lines Patch % Lines
confmap/validation.go 0.00% 2 Missing ⚠️
confmap/xconfmap/config.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #15142      +/-   ##
==========================================
- Coverage   91.24%   91.23%   -0.02%     
==========================================
  Files         701      703       +2     
  Lines       45898    45902       +4     
==========================================
- Hits        41879    41878       -1     
- Misses       2816     2820       +4     
- Partials     1203     1204       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mx-psi

mx-psi commented Apr 20, 2026

Copy link
Copy Markdown
Member

Could we share this on #otel-collector-dev and the next Collector meeting?

@mx-psi

mx-psi commented Apr 21, 2026

Copy link
Copy Markdown
Member

I'll merge this on or after 2026-04-29 unless there are blocking comments

atoulme
atoulme approved these changes Apr 22, 2026
View reviewed changes

@atoulme atoulme left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codeboten

codeboten commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

Discussed at 22-April-2026 SIG call, no concerns raised

bogdandrutu
bogdandrutu reviewed Apr 24, 2026
View reviewed changes
Comment thread confmap/xconfmap/config.go Outdated
@evan-bradley evan-bradley mentioned this pull request Apr 24, 2026
Open
@codeboten

codeboten commented Apr 27, 2026

Copy link
Copy Markdown
Contributor

@evan-bradley please resolve and we can merge 👍🏻

@codspeed-hq

codspeed-hq Bot commented May 8, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 50.88%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 2 improved benchmarks
✅ 5 untouched benchmarks
⏩ 76 skipped benchmarks1

Performance Changes

Benchmark BASE HEAD Efficiency
⚡ BenchmarkGRPCLogsSequential 6.4 ms 4.2 ms +50.88%
⚡ BenchmarkHTTPProtoLogsSequential 5.2 ms 3.6 ms +44.75%

Comparing evan-bradley:stabilize-validator (4af90dd) with main (56e1235)

Open in CodSpeed

Footnotes

  1. 76 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@mx-psi
mx-psi enabled auto-merge May 8, 2026 13:32
@mx-psi
mx-psi added this pull request to the merge queue May 8, 2026
Merged via the queue into open-telemetry:main with commit d90154d May 8, 2026
68 of 69 checks passed
swiatekm pushed a commit to swiatekm/opentelemetry-collector that referenced this pull request May 15, 2026
@evan-bradley @codeboten @swiatekm
[confmap] Stabilize confmap validation facilities (open-telemetry#15142)
63e4c09 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

The `xconfmap.Validator` interface has existed in some form for a very
long time now and is ready to be stabilized. Similarly, the
`xconfmap.Validate` method has existed in it's current state for over a
year and doesn't have any open issues I'm aware of. It should also be
ready for stabilization.

Many modules depend on `xconfmap` merely for the validation facilities
(as can be seen by the go.mod diffs), so this will allow them to depend
on only stable modules.

---------

Co-authored-by: Alex Boten <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmathieu dmathieu dmathieu approved these changes
@atoulme atoulme atoulme approved these changes
@codeboten codeboten codeboten approved these changes
@bogdandrutu bogdandrutu bogdandrutu approved these changes
@mx-psi mx-psi mx-psi approved these changes
@songy23 songy23 songy23 approved these changes
@dmitryax dmitryax Awaiting requested review from dmitryax dmitryax is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@evan-bradley @mx-psi @codeboten @dmathieu @atoulme @bogdandrutu @songy23