Skip to content

[config/configgrpc] Add DefaultLoadBalancerName constant#15139

Merged
mx-psi merged 3 commits into
open-telemetry:mainfrom
evan-bradley:configgrpc-balancername
Apr 21, 2026
Merged

[config/configgrpc] Add DefaultLoadBalancerName constant#15139
mx-psi merged 3 commits into
open-telemetry:mainfrom
evan-bradley:configgrpc-balancername

Conversation

@evan-bradley

Copy link
Copy Markdown
Member

Description

The name of the function (and fact it is a function) are slightly off to me, so this is a minor improvement to make before stabilizing the module.

Link to tracking issue

Works toward #9477

@evan-bradley
evan-bradley requested a review from a team as a code owner April 17, 2026 14:31
@evan-bradley
evan-bradley force-pushed the configgrpc-balancername branch from 0a94e31 to afa3fc5 Compare April 17, 2026 14:33
@codspeed-hq

This comment was marked as outdated.

@codecov

codecov Bot commented Apr 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 91.25%. Comparing base (307e3ab) to head (e241b54).
⚠️ Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
config/configgrpc/configgrpc.go 50.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (50.00%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15139      +/-   ##
==========================================
+ Coverage   91.24%   91.25%   +0.01%     
==========================================
  Files         699      699              
  Lines       44913    44913              
==========================================
+ Hits        40979    40986       +7     
+ Misses       2786     2782       -4     
+ Partials     1148     1145       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread config/configgrpc/configgrpc.go
Comment thread config/configgrpc/configgrpc.go
@mx-psi
mx-psi added this pull request to the merge queue Apr 21, 2026
Merged via the queue into open-telemetry:main with commit 58b846d Apr 21, 2026
103 of 110 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants