[pdata] Use pool-aware constructors in gRPC service handlers#14763
Merged
Conversation
kevinburkesegment
requested review from
a team,
bogdandrutu and
dmitryax
as code owners
March 12, 2026 23:54
kevinburkesegment
force-pushed
the
use-new-new
branch
from
March 12, 2026 23:54
a3b7ea5 to
4c4b669
Compare
Contributor
Author
|
/easycla |
kevinburkesegment
force-pushed
the
use-new-new
branch
from
March 13, 2026 03:23
4c4b669 to
6aef99c
Compare
Member
|
This should have a changelog entry. |
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (75.00%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #14763 +/- ##
==========================================
- Coverage 91.30% 90.35% -0.95%
==========================================
Files 699 700 +1
Lines 44940 53801 +8861
==========================================
+ Hits 41034 48614 +7580
- Misses 2761 4042 +1281
Partials 1145 1145 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kevinburkesegment
force-pushed
the
use-new-new
branch
2 times, most recently
from
March 16, 2026 17:02
c6192c5 to
3145851
Compare
Contributor
Author
|
Please take another look |
Contributor
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
kevinburkesegment
force-pushed
the
use-new-new
branch
from
March 31, 2026 04:16
3145851 to
c480870
Compare
Contributor
Author
|
I think this change still makes sense to merge |
dmathieu
approved these changes
Mar 31, 2026
dmathieu
left a comment
dmathieu
left a comment
Member
There was a problem hiding this comment.
Sorry for the staleness here. This definitely makes sense.
dmathieu
added
ready-to-merge
dmathieu
reviewed
Mar 31, 2026
The gRPC service handlers for all four signal types allocate the
top-level ExportXxxServiceRequest with bare new(), bypassing the
sync.Pool when pdata.useProtoPooling is enabled. This means objects
returned to the pool via Delete are never retrieved, so the pool
accumulates unreused objects.
Replace new() with the pool-aware New*() constructors so the
top-level request struct participates in the pool lifecycle.
benchstat (20 runs, pdata.useProtoPooling=true, 10k logs/request):
│ old (new()) │ new (New*()) │
│ sec/op │ sec/op vs base │
GRPCLogsSequentialPooling-12 3.858m ± 2% 3.811m ± 1% ~ (p=0.165 n=20)
│ B/op │ B/op vs base │
GRPCLogsSequentialPooling-12 3.551Mi ± 2% 3.523Mi ± 1% ~ (p=0.445 n=20)
│ allocs/op │ allocs/op vs base│
GRPCLogsSequentialPooling-12 75.46k ± 0% 75.46k ± 0% ~ (p=0.867 n=20)
No measurable perf difference (1 alloc out of 75k), but this is a
correctness fix for the pool lifecycle.
Assisted-by: Claude Opus 4.6
kevinburkesegment
force-pushed
the
use-new-new
branch
from
April 20, 2026 21:19
c480870 to
0c24389
Compare
Contributor
Author
|
@dmathieu rebased against current |
mx-psi
reviewed
Apr 22, 2026
mx-psi
approved these changes
Apr 22, 2026
mx-psi
enabled auto-merge
April 22, 2026 09:24
Merged
via the queue into
open-telemetry:main
with commit Apr 22, 2026
a54d19e
64 of 65 checks passed
Contributor
|
Thank you for your contribution @kevinburkesegment! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The gRPC service handlers for all four signal types allocate the top-level ExportXxxServiceRequest with bare new(), bypassing the sync.Pool when pdata.useProtoPooling is enabled. This means objects returned to the pool via Delete are never retrieved, so the pool accumulates unreused objects.
Replace new() with the pool-aware New*() constructors so the top-level request struct participates in the pool lifecycle.
benchstat (20 runs, pdata.useProtoPooling=true, 10k logs/request):
No measurable perf difference (1 alloc out of 75k), but this is a correctness fix for the pool lifecycle.
Assisted-by: Claude Opus 4.6
Link to tracking issue
Fixes #
Testing
Documentation