[processorhelper] report signal as attribute on incoming/outgoing items#11144
Merged
codeboten merged 3 commits intoopen-telemetry:mainfrom Sep 13, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11144 +/- ##
==========================================
- Coverage 92.29% 92.28% -0.02%
==========================================
Files 413 413
Lines 19792 19760 -32
==========================================
- Hits 18268 18236 -32
Misses 1152 1152
Partials 372 372 ☔ View full report in Codecov by Sentry. |
codeboten
commented
Sep 11, 2024
songy23
approved these changes
Sep 13, 2024
Member
songy23
left a comment
songy23
left a comment
There was a problem hiding this comment.
please rebase & resolve merge conflicts
This updating the existing metric points that were recently added to use signal as an attribute instead of separating the metric name. It follows the suggestions in otep 259 for the metric and attribute names. Signed-off-by: Alex Boten <[email protected]>
Signed-off-by: Alex Boten <[email protected]>
codeboten
force-pushed
the
codeboten/consolidate-inout-items
branch
from
7f93a32 to
fbdb5ca
Compare
codeboten
commented
Sep 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updating the existing metric points that were recently added to use signal as an attribute instead of separating the metric name. It follows the suggestions in otep 259 for the metric and attribute names.
Putting this in draft to get some feedback from @djaglowski before moving forward with this change