Update contrib version and fix diskbuffering#1326
Update contrib version and fix diskbuffering#1326breedx-splk merged 2 commits intoopen-telemetry:mainfrom
Conversation
…isk-buffering to v1.51.0-alpha
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1326 +/- ##
==========================================
- Coverage 63.97% 63.96% -0.02%
==========================================
Files 154 154
Lines 3126 3100 -26
Branches 317 315 -2
==========================================
- Hits 2000 1983 -17
+ Misses 1034 1028 -6
+ Partials 92 89 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
LikeTheSalad
left a comment
LikeTheSalad
left a comment
There was a problem hiding this comment.
Thank you for tackling this 🙏 I had an idea that it'd be quite painful, especially the test changes.
Just left a comment on your open question.
| val iter = storage.iterator() | ||
| while (iter.hasNext()) { | ||
| val result = exporter(iter.next()).join(exportTimeoutInMillis, TimeUnit.MILLISECONDS) | ||
| // TODO: What to do if a random export in the middle here just fails? |
There was a problem hiding this comment.
Calling next() from the iterator will delete the current item, so if a network export fails, I'd say we should stop the loop and try again later. Most likely, it'd be due to network connectivity issues anyway, which should come and go often, so chances are it could be fixed by the next try.
There was a problem hiding this comment.
I'll create an issue to track this and we can pick that up in a follow-up PR. Thanks for the feedback. 👍🏻
3 participants
Supersedes #1321
Hopefully I got the API usage more or less correct, and looking to @LikeTheSalad to keep me honest here.