Exclude full status on websocket reconnect#512
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #512 +/- ##
==========================================
+ Coverage 82.15% 82.19% +0.04%
==========================================
Files 28 28
Lines 2157 2162 +5
==========================================
+ Hits 1772 1777 +5
Misses 262 262
Partials 123 123 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andykellr
marked this pull request as draft
February 12, 2026 03:00
Contributor
Author
|
Marked this as draft until the opamp-spec change is merged. |
andykellr
force-pushed
the
271-modify-status-reporting-section-of-the-spec-to-allow-omitting-status-on-reconnect
branch
from
February 17, 2026 21:43
4a8c638 to
dfb5a15
Compare
andykellr
commented
Feb 17, 2026
Comment on lines
434
to
445
| func (c *wsClient) runUntilStopped(ctx context.Context) { | ||
| // Iterates until we detect that the client is stopping. | ||
| sendFirstMessage := true | ||
| for { | ||
| if c.common.IsStopping() { | ||
| return | ||
| } | ||
|
|
||
| c.runOneCycle(ctx) | ||
| c.runOneCycle(ctx, sendFirstMessage) | ||
| sendFirstMessage = false | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
As mentioned in the PR comment, this is the primary change in this PR.
andykellr
marked this pull request as ready for review
February 17, 2026 21:45
michel-laterman
approved these changes
Feb 17, 2026
tigrannajaryan
approved these changes
Feb 18, 2026
andykellr
deleted the
271-modify-status-reporting-section-of-the-spec-to-allow-omitting-status-on-reconnect
branch
February 18, 2026 19:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of optimization described here open-telemetry/opamp-spec#271
The main difference is that
runOneCycleinclient/wsclient.gonow takes asendFirstMessage booland only passes true on the first iteration. The rest of the changes are minor updates to comments, log messages, and tests.