Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.52%. Comparing base (2749d19) to head (acc1eaa).
⚠️ Report is 1 commits behind head on main.

@@            Coverage Diff             @@
##             main     #473      +/-   ##
==========================================
- Coverage   81.71%   81.52%   -0.19%     
==========================================
  Files          27       27              
  Lines        2122     2122              
==========================================
- Hits         1734     1730       -4     
- Misses        263      267       +4     
  Partials      125      125              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Please move all the files to internal/examples directory. We may have a need for docker support in the root directory later and I don't want that to interfere with examples.

@tigrannajaryan the Dockerfile files are in the root of the project because of the docker build context, allowing us to easily COPY the opamp-go library which is a local reference with replace github.com/open-telemetry/opamp-go => ../../ in the examples' go.mod
if we move the dockerfile to the examples folder, we lost the possibility of building images with our local changes.

It is a trade off. Let's find a work around

@juandemanjon: I think it could be fine with the Dockerfiles in an internal/examples folder. You can build them like so: docker build -f internal/examples/Dockerfile.agent .. This should properly build that dockerfile with the $PWD sent as context, which should prevent issues. No?

I had moved the docker files and temporarily updated the action to build with any commit

We still have .dockerignore, docker-compose.yml and makefile changes at the root. Can you move those to "examples" too? We can have a makefile in "examples" and also move existing targets from the root makefile.

I don't want to add complexity to root directory. Everything about examples should ideally be self-contained in the examples directory.

Sure, I can do that.

@tigrannajaryan before merging into main. Please, create the PACKAGES_TOKEN_GITHUB secrets as Classic secret with read, write, & delete package rights

Looks like the build succeeded: https://github.com/orgs/open-telemetry/packages?repo_name=opamp-go

Please verify published images.

The images where created, we need to improve the images tags though

https://github.com/orgs/open-telemetry/packages?tab=packages&q=opam

ghcr.io/open-telemetry/opamp-go/opamp-agent-example:renovate-actions-checkout-6.x-71b4ad5