feat: WebSocket server send error callback#427
Merged
tigrannajaryan merged 7 commits intoAug 12, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #427 +/- ##
=======================================
Coverage ? 80.16%
=======================================
Files ? 27
Lines ? 2591
Branches ? 0
=======================================
Hits ? 2077
Misses ? 396
Partials ? 118 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
The change makes sense to me. Can you add a test that verifies the new behavior (close on send error) and the new callback? |
Contributor
Author
|
@tigrannajaryan I've added the test you asked for, should be ready. |
tigrannajaryan
approved these changes
Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds functionality to the loop responsible for reading messages from the WebSocket connection to exit if we fail to send a message over the connection. This would trigger a reconnect from the client. Additionally it adds a new callback, OnMessageResponseError, that can be called in this event. This would follow behavior present when we fail to read from the connection.
Resolves #426