Support client heartbeat#296
Merged
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #296 +/- ##
==========================================
+ Coverage 77.24% 77.27% +0.02%
==========================================
Files 25 25
Lines 1692 1729 +37
==========================================
+ Hits 1307 1336 +29
- Misses 282 286 +4
- Partials 103 107 +4 ☔ View full report in Codecov by Sentry. |
haoqixu
force-pushed
the
f-heartbeat
branch
2 times, most recently
from
August 23, 2024 16:05
0ac7588 to
52d2bef
Compare
haoqixu
marked this pull request as ready for review
August 23, 2024 16:56
Member
Author
|
@jaronoff97, considering you are the author of open-telemetry/opamp-spec#190, you might find this PR of interest and perhaps may want to review it. |
jaronoff97
reviewed
Aug 28, 2024
jaronoff97
left a comment
jaronoff97
left a comment
Contributor
There was a problem hiding this comment.
just one thought, otherwise this looks great.
jaronoff97
approved these changes
Aug 28, 2024
tigrannajaryan
approved these changes
Aug 30, 2024
Member
|
Thanks @haoqixu ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement spec change open-telemetry/opamp-spec#190