Merged
Conversation
Member
|
+1 from me. |
cdunn2001
approved these changes
Oct 16, 2019
Contributor
cdunn2001
left a comment
cdunn2001
left a comment
There was a problem hiding this comment.
I checked every line in this PR. Nice. LGTM.
| decoded = -Value::LargestInt(value / 10) - last_digit; | ||
| } else if (value > Value::LargestUInt(Value::maxLargestInt)) { | ||
| decoded = -Value::LargestInt(value / 10) * 10 - last_digit; | ||
| } else if (value <= Value::LargestUInt(Value::maxLargestInt)) { |
Contributor
There was a problem hiding this comment.
Oh! This was a bug? Good catch.
Member
There was a problem hiding this comment.
Just wonder the bug, is there a example code to reproduce the bug?
dota17
approved these changes
Oct 16, 2019
dota17
reviewed
Oct 17, 2019
Contributor
I think we should prioritize that over all other work. And as implies @kimsey0 says in #1062, we really should separate the old Reader tests from CharReader tests, so we can alter them independently. We are more limited in the changes we can make to old Reader. |
Contributor
|
I think this only needs clang-format. |
Contributor
|
@baylesj: Would you clang-format this? |
Fix conflict: which has been modified in #1084
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found out today that our jsontestrunner hasn't been testing our CharReader, only the legacy Reader. I rushed out a fix for this, as part of cleaning up the logic for parsing numbers.