This repository was archived by the owner on Jan 5, 2026. It is now read-only.
Always create $(DESTDIR)/lib during make install, even on Windows#217
Merged
baentsch merged 1 commit intoopen-quantum-safe:OQS-OpenSSL_1_1_1-stablefrom Jun 26, 2020
Merged
Conversation
Cross-compiling for Windows deposits binaries in bin, not lib. Commit 72ea3e9 added rules to copy liboqs.a to OpenSSL's lib directory for development purposes, but when cross-compiling for Windows, lib hasn't been created yet. As a result, during make install, liboqs.a ends up copied and named "lib" in $(DESTDIR). This later causes a failure when it tries to create a directory there called "lib" only to find a file exists with that name. This commit causes lib to always be created in the install_runtime_libs recipe, and liboqs.a ends up in the right place.
baentsch
approved these changes
Jun 26, 2020
Member
baentsch
left a comment
baentsch
left a comment
There was a problem hiding this comment.
Thanks @kevinmkane for the explanations. Indeed I never considered Windows-specifics to be relevant when changing unix-Makefile.tmpl. This fix looks good to me.
Author
|
I wouldn't have expected it either! But now we know the template is used whenever *nix is the build platform, regardless of target. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cross-compiling for Windows deposits binaries in bin, not lib.
Commit 72ea3e9 added rules to copy
liboqs.ato OpenSSL's lib directory for development purposes, but when cross-compiling for Windows, lib hasn't been created yet.As a result, during
make install,liboqs.aends up copied and namedlibin $(DESTDIR). This later causes a failure when it tries to create a directory there calledlibonly to find a file exists with that name.This commit causes
libto always be created in theinstall_runtime_libsrecipe, andliboqs.aends up in the right place. Themkdir-p.plscript doesn't fail if it tries to create a directory that already exists as a directory, andmake installsucceeds.