fix(ast): use original var names in template error #8180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Undeclared variable errors in template string expressions were showing internal rewritten variable names (e.g., "__local2__") instead of the original names. Pass RewrittenVars map to template string rewriting functions to translate error messages back to user-visible names. Signed-off-by: Ville Vesilehto <[email protected]>
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why the changes in this PR are needed?
When a template string expression contains an undeclared variable, the compiler was reporting the internal rewritten variable name (e.g.,
__local2__) instead of the original variable name. This is described in issue #8157.What are the changes in this PR?
The rewrite map
RewrittenVarsis now passed through template string rewriting functions. The rewritten variable names are translated back to original names when errors are being generated.There actually was a test case already for this marked with
FIXME. The test is now fixed and I also added a regression test from #8157.Notes to assist PR review:
The
RewriteLocalVarscompiler stage runs beforeRewriteTemplateStrings, so variables have already been renamed to internal names by the time template string safety checks run. The fix follows the same pattern used elsewhere like insafetyErrorSliceandcheckSafetyRuleHeads.Further comments:
Fixes #8157.