parser: string template and unescaping nitpicks #8135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I'm on battery right now, will check the benchmarks when back at my plug. |
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
srenatus
commented
Dec 17, 2025
| StringTerm("/𝄞"), | ||
| ), | ||
| }, | ||
| }, |
Contributor
Author
There was a problem hiding this comment.
I had believed for a moment that we could use strconv.Unquote, but these are some characters where this differs from the JSON unescaping. So, added a case just to be explicit.
Contributor
Author
|
Contributor
Author
|
Some diffs there are a bit mysterious, but I think it's overall going into the right direction. 🔍 |
Contributor
Author
Hmm what is this? Now it went the other way. Above, the diff was -75% 😮 |
Contributor
Author
|
OK the bottom line is: allocs go down for string-heavy parsing, as expected: |
This should avoid a couple of allocations. Signed-off-by: Stephan Renatus <[email protected]>
For string templates, the snippets to iterate over are expected to be small, so this shouldn't be much extra work. At any rate, avoiding to go through `json.Unmarshal` is probably a good idea if possible. Signed-off-by: Stephan Renatus <[email protected]>
srenatus
force-pushed
the
sr/osxzpsnrnpkt
branch
from
333ebbb to
52df2d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Haven't found the benchmark where this changes things. But it looks worthwhile, avoiding a bunch of allocs.