perf: 10% faster compilation #8078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
srenatus
approved these changes
Nov 27, 2025
Contributor
srenatus
left a comment
srenatus
left a comment
There was a problem hiding this comment.
Nice work 👏 Just a nitpick re: removing an exported method
anderseknert
force-pushed
the
walk-now-runs
branch
from
6169c4f to
60ffe1e
Compare
Or something in that ballpark. This is accomplished by tweaking existing walk/visitor implementations where appropriate, and by introducing a new visitor type that while more limited, is able to perform much better where it can be used. Most impressive of the improvements here is the new `WalkRules` implementation, as the benchmark included in this change shows. The most impactful change is however the improved use of the various `VarVisitor`s used during the compilation process. Compiling the Regal bundle: **OPA v1.11.0 (main)** ``` 67207511 ns/op 42652069 B/op 1032387 allocs/op ``` **Now** ``` 62502125 ns/op 35918354 B/op 929634 allocs/op ``` Signed-off-by: Anders Eknert <[email protected]>
anderseknert
force-pushed
the
walk-now-runs
branch
from
60ffe1e to
1ac9ed7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Or something in that ballpark. This is accomplished by tweaking existing walk/visitor implementations where appropriate, and by introducing a new visitor type that while more limited, is able to perform much better where it can be used. Most impressive of the improvements here is the new
WalkRulesimplementation, as the benchmark included in this change shows. The most impactful change is however the improved use of the variousVarVisitors used during the compilation process.Compiling the Regal bundle:
OPA v1.11.0 (main)
Now