New custom SemVer implementation #8010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
anderseknert
force-pushed
the
new-semver
branch
3 times, most recently
from
be31dd3 to
dddea4d
Compare
srenatus
approved these changes
Nov 4, 2025
This was something I originally intended to use in another project, but since this turned out to be a better implementation (subject of course to review!) in terms of both performance and simplicity, I figured we might as well use it here too. Some changes include: - `MustParse` to parse known valid versions - Allocates nothing in any operations other than 1 alloc in `String()` - Ignores empty `PreRelease` and `Metadata` fields in serialization - `encoding.TextAppender` implementation to serialize without allocating - A whole bunch of benchmarks Signed-off-by: Anders Eknert <[email protected]>
anderseknert
force-pushed
the
new-semver
branch
from
dddea4d to
ae43df8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was something I originally intended to use in another project, but since this turned out to be a better implementation (subject of course to review!) in terms of both performance and simplicity, I figured we might as well use it here too. Some changes include:
MustParseto parse known valid versionsString()PreReleaseandMetadatafields in serializationencoding.TextAppenderimplementation to serialize without allocating