server/failtracer: don't assume only being fed two-elem calls #7995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was overly specific before, and quickly failed when fail events had not been on of the right sort. Now, we're more lenient. These would happen, as in https://github.com/orgs/open-policy-agent/discussions/722#discussioncomment-14812737, when a fail event happened that's unrelated to unknowns lookup, but a valid failure nonetheless. So this will not lead to a hint. Only fail events of the previously-expected form could yield hints. Signed-off-by: Stephan Renatus <[email protected]>
srenatus
commented
Oct 29, 2025
| switch { | ||
| case expr.IsCall(): | ||
| for i := range 2 { | ||
| op := expr.Operand(i) |
Contributor
Author
There was a problem hiding this comment.
@philipaconrad I vaguely remember you having pointed at this line with concerns before. If my recollection is correct: you win! 🙃
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was overly specific before, and quickly failed when fail events had not been on of the right sort. Now, we're more lenient.
These would happen, as in https://github.com/orgs/open-policy-agent/discussions/722#discussioncomment-14812737, when a fail event happened that's unrelated to unknowns lookup, but a valid failure nonetheless. So this will not lead to a hint. Only fail events of the previously-expected form could yield hints.
Reported by @huntkalio