Modernize analyzer fixes #7965
Merged
Modernize analyzer fixes #7965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Have done this some time in the past, but there was a few new issues this would highlight now that we're on Go 1.24. Mostly: - Use `b.Loop()` in benchmarks - Use `strings.SplitSeq` where possible - Remove `omitempty` tag for types that can't be empty Signed-off-by: Anders Eknert <[email protected]>
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
philipaconrad
approved these changes
Oct 9, 2025
Member
philipaconrad
left a comment
philipaconrad
left a comment
There was a problem hiding this comment.
After reading through the changes, this PR is exactly what it claims to be: a lot of small, repetitive modernization changes to bring our testing/benchmarking code in line with the tools available in modern Golang. (b.Loop, string splitting iterators, etc.)
Thanks for trawling through the testing and benchmarking code for this PR @anderseknert!
| a := header.Get("Accept-Encoding") | ||
| parts := strings.Split(a, ",") | ||
| for _, part := range parts { | ||
| for part := range strings.SplitSeq(header.Get("Accept-Encoding"), ",") { |
Member
There was a problem hiding this comment.
I like how much the iterator cleans things up here. 🙂
Signed-off-by: Anders Eknert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have done this some time before, but there were a few new issues this would highlight now that we're on Go 1.24.
Mostly:
b.Loop()in benchmarksstrings.SplitSeqwhere possibleomitemptytag for types that can't be empty