Skip to content

Conversation

@srenatus
Copy link
Contributor

Follow-up to #7887.

@srenatus srenatus force-pushed the sr/quqyssromwkz branch 2 times, most recently from d0acead to 80e2aeb Compare September 25, 2025 11:38
@netlify
Copy link

netlify bot commented Sep 25, 2025

Deploy Preview for openpolicyagent ready!

Name Link
🔨 Latest commit 6c7caeb
🔍 Latest deploy log https://app.netlify.com/projects/openpolicyagent/deploys/68d52941627a7e0008a54a11
😎 Deploy Preview https://deploy-preview-7939--openpolicyagent.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Sep 25, 2025

Deploy Preview for openpolicyagent ready!

Name Link
🔨 Latest commit 303e5c3
🔍 Latest deploy log https://app.netlify.com/projects/openpolicyagent/deploys/68db854db904040008d75170
😎 Deploy Preview https://deploy-preview-7939--openpolicyagent.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

items: [
{ type: "autogenerated", dirName: "filtering" },
],
},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to discuss a better place, or rank, for this category 😎

@srenatus srenatus marked this pull request as ready for review September 25, 2025 12:02
title: Overview
sidebar_position: 1
---

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like some preamble here would be helpful, outlining what this new section is all about and what the value we can offer for the use case is.

</SideBySideColumn>
</SideBySideContainer>

---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason in particular reason to have these? We tend not to have them quite so often on other pages.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's separating the steps... The content would work better as a slide-show, but that's too much for the docs. I can remove them, but I think it doesn't work out too bad this way, do you?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I don't have strong feelings - perhaps numbered steps would make it clear too? just an idea...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mean like "Step 1", "Step 2", ... subheadings?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be worth a shot, but not essential and don't waste time with it if it doesn't look right with the default markdown available.

@@ -0,0 +1,218 @@
---
title: Writing valid data filtering policies
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: Writing valid data filtering policies
title: Writing Valid Data Filtering Policies

<TabItem value="rego" label="filters.rego" default>

```rego
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change


#### Request

```http
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```http
```http title="Request"

We can also do this, if you don't need the anchor

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautilful 👨‍🍳 Thanks for the hint!
image


#### Response

```http
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```http
```http title="Response"

srenatus and others added 2 commits September 30, 2025 09:07
Upon reading this again, I found it confusing. I think it's slightly
less so now.

Also adds a row for the lonely statements supported in the next release.

Signed-off-by: Stephan Renatus <[email protected]>
This is everything we've had in EOPA, with updated cross-references,
updated annotations (custom -> compile) and headers.

This is work done in another repository, so I'll collect co-authors on
this commit message's trailers.

Co-authored-by: Philip Conrad <[email protected]>
Co-authored-by: Chris Hendrix <[email protected]>
Signed-off-by: Stephan Renatus <[email protected]>
@srenatus srenatus force-pushed the sr/quqyssromwkz branch 3 times, most recently from e2ff8df to 2f67550 Compare September 30, 2025 07:20
Signed-off-by: Stephan Renatus <[email protected]>
@srenatus srenatus merged commit 8a2afe8 into open-policy-agent:main Oct 1, 2025
31 checks passed
@srenatus srenatus deleted the sr/quqyssromwkz branch October 1, 2025 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants