Bump golangci-lint to v2.4.0 #7878
Merged
+245
−211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastian Spaink <[email protected]>
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a major version bump for
golangci-lint: https://ldez.github.io/blog/2025/03/23/golangci-lint-v2/Ran
golangci-lint migrateas suggested in this guide. Only changes I had to make was to move the comments and add the timeout back. I think everything else stayed the same.The
statichecklinter has somequickfixrules enabled by default now, I decided to disable most of them as they seemed optional with little benefit. The rules are QF1001, QF1002, QF1003, QF1008, QF1009, QF1012. You can find more details here: https://staticcheck.dev/docs/checks/#QF1003. Definitely worth considering to enable them, but thought it would be better on a case-by-case basis.