cmd/exec: Update tests to run sync when ready #7835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlieegan3
commented
Aug 12, 2025
| return err == nil && resp.StatusCode == 200 | ||
| }) | ||
|
|
||
| _ = runExec(params) |
Contributor
Author
There was a problem hiding this comment.
I felt it was ok to just check the logged errors since we're in the cmd package. For me, it made the tests easier to follow.
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
charlieegan3
force-pushed
the
cmd-exec-test
branch
from
6c01bf8 to
43395fb
Compare
philipaconrad
approved these changes
Aug 19, 2025
Member
philipaconrad
left a comment
philipaconrad
left a comment
There was a problem hiding this comment.
This looks like a good cleanup to me! Sorry I didn't notice the review request sooner-- it got buried in the general notification spam. 🙃
Contributor
Author
|
Thanks for the review, I was mega slow to get back to this after a trip last week so I'll sort it out later. |
charlieegan3
force-pushed
the
cmd-exec-test
branch
4 times, most recently
from
14bb17a to
27bad57
Compare
johanfylling
approved these changes
Aug 27, 2025
cmd/exec_test.go
Outdated
|
|
||
| // when bundles fail to parse, OPA never signals the ready channel, causing | ||
| // runExec to hang indefinitely. WithContext allows us to cancel the context | ||
| // when when we have the required errors logged. |
Contributor
Author
There was a problem hiding this comment.
Ahh, fixed that too!
Following: open-policy-agent#7821 I think we can avoid using the async running of exec when we know the bundle server is ready to go. I saw some more issues from these tests in https://github.com/open-policy-agent/opa/actions/runs/16905415883/job/47894071103?pr=7825 and am trying to make them more reliable this way. Signed-off-by: Charlie Egan <[email protected]>
charlieegan3
force-pushed
the
cmd-exec-test
branch
from
27bad57 to
9b630a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following: #7821 I think we can avoid using the async running of exec when we know the bundle server is ready to go.
I saw some more issues from these tests in
https://github.com/open-policy-agent/opa/actions/runs/16905415883/job/47894071103?pr=7825 and am trying to make them more reliable this way.
I left the async that's needed in TestExecWithBundleRegoVersion where runExec does not complete, here we just wait for the messages and then stop, but now we shutdown the goroutine nicely.