btl/vader: ensure that the send tag is always written last#5696
Merged
hjelmn merged 1 commit intoopen-mpi:masterfrom Sep 14, 2018
Merged
btl/vader: ensure that the send tag is always written last#5696hjelmn merged 1 commit intoopen-mpi:masterfrom
hjelmn merged 1 commit intoopen-mpi:masterfrom
Conversation
To ensure fast box entries are complete when processed by the receiving process the tag must be written last. This includes a zero header for the next fast box entry (in some cases). This commit fixes two instances where the tag was written too early. In one case, on 32-bit systems it is possible for the tag part of the header to be written before the size. The second instance is an ordering issue. The zero header was being written after the fastbox header. Fixes open-mpi#5375, open-mpi#5638 Signed-off-by: Nathan Hjelm <[email protected]>
This was referenced Sep 14, 2018
Member
|
In talking to @hjelmn in IM, he points out that this bug is not silent data corruption, but rather will just cause a hang or crash. It's still a pretty serious bug, but at least it's not silent data corruption. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To ensure fast box entries are complete when processed by the
receiving process the tag must be written last. This includes a zero
header for the next fast box entry (in some cases). This commit fixes
two instances where the tag was written too early. In one case, on
32-bit systems it is possible for the tag part of the header to be
written before the size. The second instance is an ordering issue. The
zero header was being written after the fastbox header.
Fixes #5375, #5638
Signed-off-by: Nathan Hjelm [email protected]