Repository navigation
docs(olai-delta-df): trim AI/session-artifact comment cruft - #132
Merged
Merged
Conversation
roeap
marked this pull request as ready for review
July 18, 2026 08:17
Sweep the whole crate for comments that only made sense to someone who
read an ephemeral planning doc, and cut them back to what a reviewer or
future developer actually needs:
- Drop planning/handover-doc and milestone labels (M0-M3, "Stage 4/5",
"narrow waist", handover-*.md references).
- Drop porting/POC history ("Ported from the kernel POC", "Unlike the
POC", "replaces the eager InlineExecutor/PrimedStore", "reconciled to
DataFusion 54") — describe the code as it is, not how it got here.
- Drop internal issue/PR references (mangrove#28/#116/#123) and
"belt-and-suspenders" / "not required today" filler; keep the
load-bearing external pointer (apache/datafusion#20432).
- De-duplicate comments that restated an adjacent doc comment verbatim.
Preserved every genuine "why": the per-row deletion-vector guard, the
wasm block_on/getrandom constraints, the leaf-pushdown workaround, the
partition-column metadata strip, and the kernel-API quirks. Comment-only
change; `cargo check`/`cargo doc` still pass.
AI-assisted-by: Isaac
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
roeap
force-pushed
the
cleanup-olai-delta-df-comments
branch
from
July 18, 2026 08:18
8f70511 to
9643ee1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
olai-delta-dfcrate accumulated a lot of comment cruft over successive sessions — the telltale signs of AI-written/session-artifact comments. This sweep cleans the whole crate (all ofsrc/andtests/) back to comments that a reviewer or future developer actually needs.Removed:
handover-*.mdreferences,M0–M3"verification" prefixes,Stage 4/Stage 5/Stage-3labels, "narrow waist".InlineExecutor/PrimedStore", "Reconciled to DataFusion 54.0.0". The code is now described as it is, not how it got here.mangrove#28/#116/#123, "belt-and-suspenders", "not required today", meta-notes about prior comments ("an earlier comment referenced X that never existed").block_oncaveat repeated three times insnapshot_build.rs).Preserved every genuine why: the per-row deletion-vector guard, the wasm
block_on/getrandomconstraints, the leaf-expression-pushdown workaround (apache/datafusion#20432— a real external pointer, kept), the partition-column metadata strip, and the kernel-API quirks.Test plan
cargo fmt -p olai-delta-df --checkclean.cargo check -p olai-delta-df --all-featurespasses.cargo doc -p olai-delta-df --no-depsbuilds (pre-existing private-item link warnings only; no new links introduced).This pull request was AI-assisted by Isaac.