Repository navigation
Commit 115587e
CI (docs-lint, plugin-validate) failed with "N tests registered, M reported" while
the TAP summary itself said M, so the accounting was right and results really did
not reach the report. Root cause, from node's v24 runner source and measured on a
Linux node:24 container: the runner forwards --test-force-exit to every test-file
child (getRunArgs); each forced child calls process.exit() the moment its root test
ends, and its stdout, the pipe its V8-framed results travel on, is non-blocking on
POSIX, so frames still queued in the Socket are discarded (nodejs/node#64833, fix
proposed in nodejs/node#64875). It needs no concurrency: plugin-validate lost 23 of
54 in a single file.
Measurement (Node 24.18.0, Linux, 20 files x 300 tests, concurrency 8, the runner's
own events file and ledger, 4 runs each): count-only preload 5049-5074 reported of
6000 (ledger 6000: the child had emitted them all, so the loss is child to parent);
preload that makes the child's stdout blocking 6000/6000 on every run; without
force-exit 6000/6000.
registration-ledger-preload.cjs now sets the child's stdout handle blocking at load
(blockChildStdout, best-effort, test-file children only), the same operation the
upstream fix performs at force-exit, but done up front so nothing is ever queued.
--test-force-exit stays on every platform: it is the Windows post-test hang guard
(#1051) and nothing about that changes, whereas dropping it on POSIX would trade a
loud accounting failure for silent hangs on leaked handles. The accounting stays as
the backstop for any other loss. Unit rows pin blockChildStdout; the behavioral proof
is a real shard's own accounting.
Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
1 parent a18dbbc commit 115587e
3 files changed
Lines changed: 70 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
47 | | - | |
48 | | - | |
49 | | - | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
50 | 53 | | |
51 | 54 | | |
52 | 55 | | |
| |||
98 | 101 | | |
99 | 102 | | |
100 | 103 | | |
101 | | - | |
102 | | - | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
103 | 139 | | |
104 | | - | |
| 140 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1251 | 1251 | | |
1252 | 1252 | | |
1253 | 1253 | | |
1254 | | - | |
1255 | | - | |
1256 | | - | |
| 1254 | + | |
| 1255 | + | |
| 1256 | + | |
| 1257 | + | |
1257 | 1258 | | |
| 1259 | + | |
| 1260 | + | |
| 1261 | + | |
1258 | 1262 | | |
1259 | 1263 | | |
1260 | 1264 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
380 | 380 | | |
381 | 381 | | |
382 | 382 | | |
| 383 | + | |
| 384 | + | |
| 385 | + | |
| 386 | + | |
| 387 | + | |
| 388 | + | |
| 389 | + | |
| 390 | + | |
| 391 | + | |
| 392 | + | |
| 393 | + | |
| 394 | + | |
| 395 | + | |
| 396 | + | |
| 397 | + | |
| 398 | + | |
| 399 | + | |
| 400 | + | |
| 401 | + | |
| 402 | + | |
| 403 | + | |
383 | 404 | | |
384 | 405 | | |
385 | 406 | | |
| |||
0 commit comments