feat: blocking setProvider#201
Merged
justinabrahms merged 10 commits intomainfrom Aug 15, 2023
Merged
Conversation
thomaspoignant
force-pushed
the
set-provider-wait
branch
from
43975bf to
2868f6f
Compare
toddbaert
reviewed
Aug 14, 2023
toddbaert
reviewed
Aug 14, 2023
toddbaert
reviewed
Aug 14, 2023
toddbaert
approved these changes
Aug 14, 2023
toddbaert
requested review from
agentgonzo,
bacherfl,
jonathannorris,
justinabrahms,
kinyoklion,
lopitz,
tcarrio and
weyert
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
This reverts commit a26f27b. Signed-off-by: Thomas Poignant <[email protected]>
Co-authored-by: Todd Baert <[email protected]> Signed-off-by: Thomas Poignant <[email protected]> Signed-off-by: Thomas Poignant <[email protected]>
Co-authored-by: Todd Baert <[email protected]> Signed-off-by: Thomas Poignant <[email protected]> Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
thomaspoignant
force-pushed
the
set-provider-wait
branch
from
a98f31a to
ee80ce2
Compare
beeme1mr
approved these changes
Aug 14, 2023
justinabrahms
approved these changes
Aug 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Following this OFEP adding a SHOULD to the spec to have a blocking
setProvider.