Conversation
* loosen shutdown requirements to support things like go ctx * clarify how to handle init/shutdown of providers bound to multiple names * clarify init function should terminate before provider used Signed-off-by: Todd Baert <[email protected]>
toddbaert
requested review from
Kavindu-Dodan,
beeme1mr,
kinyoklion,
lopitz,
lukas-reining and
weyert
Signed-off-by: Todd Baert <[email protected]>
Kavindu-Dodan
left a comment
Kavindu-Dodan
left a comment
There was a problem hiding this comment.
Approving - Open discussions can be finalized on agreements and personaly I don't see them to conflict a lot
Signed-off-by: Todd Baert <[email protected]>
lukas-reining
left a comment
lukas-reining
left a comment
There was a problem hiding this comment.
Looks good to me now and the changes are really good to me!
|
The spec shows that the initialization accepts a global context as a parameter. However the java sdk provider interface has the initialization API without any parameters. Is there any discussion regarding that? |
I think this is an oversight. I will open an issue in the Java SDK (we haven't released yet, so no issue). Great find. |
9 participants
API.shutdown()required in Go? #189clarify init function should terminate before provider used feat: add initialize and shutdown behavior java-sdk#456 (comment)cc @open-feature/technical-steering-committee @lopitz @lukas-reining @kinyoklion @Kavindu-Dodan
Definitely let me know anyone thinks something is missing or could be improved here.