Merged
Conversation
toddbaert
commented
Apr 4, 2023
toddbaert
commented
Apr 4, 2023
toddbaert
requested review from
Kavindu-Dodan,
RealAnna,
bacherfl,
benjiro,
cdonnellytx,
dabeeeenster,
davejohnston,
james-milligan,
josecolella,
justinabrahms,
kinyoklion,
markphelps,
patricioe,
rgrassian-split,
skyerus,
tcarrio,
thiyagu06 and
weyert
beeme1mr
reviewed
Apr 4, 2023
kinyoklion
reviewed
Apr 13, 2023
beeme1mr
approved these changes
Apr 26, 2023
Member
beeme1mr
left a comment
beeme1mr
left a comment
There was a problem hiding this comment.
Looks great! It's a small but important feature.
thomaspoignant
approved these changes
May 2, 2023
Member
thomaspoignant
left a comment
thomaspoignant
left a comment
There was a problem hiding this comment.
Super nice addition, this is actually something I already need in the GO SDK.
weyert
approved these changes
May 2, 2023
toddbaert
force-pushed
the
feat/init-and-shutdown
branch
2 times, most recently
from
6ebf587 to
d64f3c4
Compare
lukas-reining
approved these changes
May 6, 2023
Member
lukas-reining
left a comment
lukas-reining
left a comment
There was a problem hiding this comment.
Looks good to me now! 🙂
justinabrahms
approved these changes
May 8, 2023
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
…for readiness Signed-off-by: Todd Baert <[email protected]>
Co-authored-by: Justin Abrahms <[email protected]> Signed-off-by: Todd Baert <[email protected]>
Co-authored-by: Justin Abrahms <[email protected]> Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Co-authored-by: Jonathan Norris <[email protected]> Signed-off-by: Lukas Reining <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
toddbaert
force-pushed
the
feat/init-and-shutdown
branch
from
db43992 to
bdb4ee4
Compare
Signed-off-by: Todd Baert <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds initialization and shutdown discussed in DRAFT client PR, and OFEPs. This is a piece of the (too big) draft PR here. The changes are fairly small and non-breaking.
There's a few non-functional changes here (fixes to formatting and minor enhancements to the parser).
Be sure to review
specification.jsonfor the net changes.Most of this is implemented in the web-sdk already. Some conforming (demo) providers can be found in the playground: