feat: add proposal for dispose functionality#46
Merged
Conversation
Signed-off-by: Todd Baert <[email protected]>
toddbaert
force-pushed
the
add-dispose-otep
branch
from
c3d0c58 to
62b9ad9
Compare
beeme1mr
reviewed
Feb 3, 2023
Member
beeme1mr
left a comment
beeme1mr
left a comment
There was a problem hiding this comment.
I believe we'll need to call the dispose method on an existing provider if a new one is registered.
Co-authored-by: Michael Beemer <[email protected]> Signed-off-by: Todd Baert <[email protected]>
Co-authored-by: Michael Beemer <[email protected]> Signed-off-by: Todd Baert <[email protected]>
Co-authored-by: Michael Beemer <[email protected]> Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
toddbaert
commented
Feb 3, 2023
Signed-off-by: Todd Baert <[email protected]>
toddbaert
requested review from
InTheCloudDan,
Kavindu-Dodan,
agentgonzo,
beeme1mr,
benjiro,
dabeeeenster,
davejohnston,
jakedoublev,
james-milligan,
josecolella,
justinabrahms,
kinyoklion,
markphelps,
moredip,
skyerus,
tcarrio,
thiyagu06 and
thomaspoignant
Member
Author
|
This one is pretty straightforward. Let's see if we can't get a couple approvals on this - it's not a spec, we just need a general consensus that this is a good idea ™️ |
kinyoklion
reviewed
Feb 15, 2023
beeme1mr
approved these changes
Feb 15, 2023
Member
beeme1mr
left a comment
beeme1mr
left a comment
There was a problem hiding this comment.
Added a minor suggestion but the core concept is solid.
Co-authored-by: Michael Beemer <[email protected]> Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
kinyoklion
approved these changes
Feb 15, 2023
weyert
approved these changes
Feb 15, 2023
skyerus
approved these changes
Feb 16, 2023
thiyagu06
reviewed
Feb 17, 2023
benjiro
approved these changes
Feb 19, 2023
Co-authored-by: Thiyagu GK <[email protected]> Signed-off-by: Todd Baert <[email protected]>
toddbaert
commented
Feb 21, 2023
Signed-off-by: Todd Baert <[email protected]>
Member
Author
|
It seems like we have a broad consensus here. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues: #30, opened by @weyert byt closed due to some git-trouble.