feat: add proposal for dispose functionality#30
feat: add proposal for dispose functionality#30weyert wants to merge 56 commits intoopen-feature:mainfrom
Conversation
Beeme1mr/issue2
Signed-off-by: Alex Jones <[email protected]>
Signed-off-by: Alex Jones <[email protected]>
Signed-off-by: ssen <[email protected]>
Signed-off-by: ssen <[email protected]>
Modified the after hook order based on comments Signed-off-by: ssen <[email protected]>
Signed-off-by: Michael Beemer <[email protected]>
Add proposal for Provider Hook
Signed-off-by: Alex Jones <[email protected]>
Signed-off-by: Alex Jones <[email protected]>
Signed-off-by: Alex Jones <[email protected]>
006-OFEP-flagd-sockets
This doesn't seem necessary. You could just reregister a provider to reinitialize a provider that was shutdown. |
I had the same thought. We could do it this way, but re-registering the same provider feels a bit odd. Maybe it actually makes the most sense though. I don't feel too strongly about that one either way. |
This is really interesting. I hadn't experienced a use case of multiple |
OpenFeature is currently designed that you can only have a single instance of the API, and one or more clients. So the case of many clients will need to be handled. |
I think registering a provider makes sense. I am doubtful registering the same provider (as in same instance) would make sense, as the provider would already be closed, so you would still need some means to tell it not to be closed. (The way my provider currently works, if it were to be closed somehow, then it couldn't really be started again.) |
Great point. If some providers implement a means of "re-initialization", I think that's their business, and we can leave the SDK out of it. The SDK will simply use whatever provider is set, and if the state of readiness is maintained with the provider, we don't need to define "re-initialization" behavior on the SDK. |
|
@jakedoublev with regards to multiple clients, this bit of doc may be helpful. |
* Update and rename OFEP-provider-metadata-feature-discovery.md to OFEP-provider-metadata-capability-discovery.md Signed-off-by: Todd Baert <[email protected]>
|
Hey @weyert, would you be able to address the feedback and sign off your commits? This is a pre-req for some upcoming client-side changes. Thanks! |
Co-authored-by: Todd Baert <[email protected]> Signed-off-by: Weyert de Boer <[email protected]>
Co-authored-by: Todd Baert <[email protected]> Signed-off-by: Weyert de Boer <[email protected]>
I have applied the suggestions and signed them off. I will have a closer look what is needs to be done based on the comments |
2389c80 to
db03bba
Compare
Add the ability to dispose of resources consumed by the
OpenFeature Provider. For example, when a provider uses asetIntervalor registers an event handler then they should be released and currently this is not possible