Skip to content

006-OFEP-flagd-sockets#27

Merged
AlexsJones merged 3 commits intomainfrom
ofep/sockets
Aug 9, 2022
Merged

006-OFEP-flagd-sockets#27
AlexsJones merged 3 commits intomainfrom
ofep/sockets

Conversation

@AlexsJones
Copy link
Copy Markdown
Member

This pull request outlines the proposal to introduce unix sockets into flagD

Signed-off-by: Alex Jones <[email protected]>
Signed-off-by: Alex Jones <[email protected]>
@AlexsJones AlexsJones changed the title ofep sockets 006-OFEP-flagd-sockets Aug 6, 2022
@toddbaert
Copy link
Copy Markdown
Member

I don't have much to say other than I agree with this, even if it's not a top priority, I think it should be done.

As a possibly interesting data point, redis has some interesting throughput benchmarks for IPC/Unix sockets vs TCP: https://redis.io/docs/reference/optimization/benchmarks/

Copy link
Copy Markdown
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the OFEP state to APPROVED before merging.

@AlexsJones AlexsJones merged commit 156cd80 into main Aug 9, 2022
@AlexsJones AlexsJones deleted the ofep/sockets branch August 9, 2022 06:58
weyert pushed a commit to weyert/research that referenced this pull request Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants