Merged
Conversation
Signed-off-by: Alex Jones <[email protected]>
Signed-off-by: Alex Jones <[email protected]>
77db6a8 to
d2403df
Compare
Member
|
I don't have much to say other than I agree with this, even if it's not a top priority, I think it should be done. As a possibly interesting data point, redis has some interesting throughput benchmarks for IPC/Unix sockets vs TCP: https://redis.io/docs/reference/optimization/benchmarks/ |
toddbaert
approved these changes
Aug 8, 2022
beeme1mr
approved these changes
Aug 8, 2022
Member
beeme1mr
left a comment
There was a problem hiding this comment.
Please update the OFEP state to APPROVED before merging.
Signed-off-by: Alex Jones <[email protected]>
weyert
pushed a commit
to weyert/research
that referenced
this pull request
Jan 31, 2023
006-OFEP-flagd-sockets
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request outlines the proposal to introduce unix sockets into flagD