Merged
Conversation
Signed-off-by: Alex Jones <[email protected]>
thomaspoignant
approved these changes
Jul 12, 2022
toddbaert
reviewed
Jul 12, 2022
| Given we are looking to now expand to offer new generated server support for gRPC, we are in a predicament about whether to a) derive the implementation from OpenAPI b) have a new source of truth as .proto files c) have some sort of composite between the two. | ||
|
|
||
| My proposal here would be to choose a new top-level DSL to define the specifications required to drive generated server code implementations. As such, cue offers integration with YAML/JSON & protobuf directly. | ||
| This would mean we could use a single file(s) and toolchain to generate all of the automatically created code for flagD. |
Member
There was a problem hiding this comment.
nitpick: I'd like to get consensus on the casing style here. I have leaned toward "flagd" in the pattern of "etcd", "systemd", etc, but consistency is more important to me than the choice we make.
Maybe we need some official doc on this?
Member
Author
There was a problem hiding this comment.
To be honest, this was a direct back port out of the issue so there are probably going to be dime a dozen of these kinds of issues.
Why don't you put it into 000-OFP-template?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open Feature enhancement proposal, initial draft and backport
OFEP's are born.
#19